Migrate LatLngBounds to nullsafety #1431
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGES
Updated
LatLngBounds
constructor and its methods to rely on non-nullable values.Migration guide
BAD:
GOOD:
And all method related to the
LatLngBounds
now relies on non-nullable parameters and returns non-nullable values:LatLngBounds
: takes 2LatLng
parameters instead ofLatLng?
extend()
: takes aLatLng
instead ofLatLng?
southWest
: returns aLatLng
instead ofLatLng?
northEast
: returns aLatLng
instead ofLatLng?
isValid
: became deprecated as it'll always be truecontains()
: takes aLatLng
instead ofLatLng?
isOverlapping()
: takes aLatLngBounds
instead ofLatLngBounds?
I've added some unit tests to ensure that the values are still relevant even after the migration.